mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[DataGrid] Preprocess edit cell props on backspace/delete

Open kenanyusuf opened this issue 1 year ago • 4 comments

Calls preProcessEditCellProps when a cell contents is deleted by the backspace/delete key.

Before: https://codesandbox.io/p/sandbox/15151-preprocess-edit-cell-on-delete-after-forked-7vwlyg After: https://codesandbox.io/p/sandbox/elegant-pond-nchrgq

Closes #15058

kenanyusuf avatar Oct 28 '24 13:10 kenanyusuf

Deploy preview: https://deploy-preview-15151--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against a927b5d465503b0fd77ca252ccd4675a1967e214

mui-bot avatar Oct 28 '24 13:10 mui-bot

Can you add a test for this?

arminmeh avatar Oct 30 '24 10:10 arminmeh

Can you add a test for this?

@arminmeh I have added a basic test for cell and row editing - anything else you think should be tested?

kenanyusuf avatar Oct 30 '24 10:10 kenanyusuf

I have added a basic test for cell and row editing - anything else you think should be tested?

Ignore 😆 Collapsed the files when I started. Continued review today, forgot about the test being there 😅

arminmeh avatar Oct 30 '24 11:10 arminmeh