mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[TreeView] TreeItem2DragAndDropOverlay has no border/background style

Open kzimins-arvatosystems opened this issue 1 year ago • 1 comments

Steps to reproduce

Related to #14969

css definition of border style is wrong image correct rgba syntax is rgba(red, green, blue, alpha) image

Same for action make-child image

Current behavior

css is wrong

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: treeview, cssvars Order ID: 80084

kzimins-arvatosystems avatar Oct 18 '24 08:10 kzimins-arvatosystems

Thank you for opening this issue @kzimins-arvatosystems 🙏 It is our oversight. 🙈 For any rgba calls only <color>Channel can be used.

LukasTy avatar Oct 18 '24 14:10 LukasTy

It seems to be an issue with the use of RGB variables. The format for RGB in CSS variables should be three comma-separated numbers, representing the red, green, and blue channels (values ranging from 0 to 255), such as 0, 72, 118. ex: image rgb(var(--dc01-rgb) / 0.15) is valid

wangkailang avatar Oct 21 '24 02:10 wangkailang

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

[!NOTE] @kzimins-arvatosystems How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

github-actions[bot] avatar Oct 22 '24 11:10 github-actions[bot]

@LukasTy Hi!

After today's release, I'm still experiencing issues with styles. rgba(hex / opacity) and rgba(rgb / opacity) doesn't seem to be valid syntax, probably must be rgb, so right syntax may be: image

but got image image

Also, TreeItem2DragAndDropOverlay is not exported from the pro package. I'm importing everything else from the pro package, so could this be the cause of the issue?

image

kzimins-arvatosystems avatar Oct 25 '24 16:10 kzimins-arvatosystems

Hello @kzimins-arvatosystems I'm sorry to hear you are still experiencing issues with this. 🙈 That's my bad, I applied the fix on the master branch but forgot to cherry-pick it to the current stable release. Is it blocking you, or can you wait for the next release this Thursday? 🤔

Also, TreeItem2DragAndDropOverlay is not exported from the pro package. I'm importing everything else from the pro package, so could this be the cause of the issue?

It is re-exported from @mui/x-tree-view-pro root. We do not re-create the folder structure on the commercial packages to re-export files from community package with the same path. The import path shouldn't change anything, but feel free to import it from the pro package with the following line:

import { TreeItem2DragAndDropOverlay } from '@mui/x-tree-view-pro';

LukasTy avatar Oct 28 '24 08:10 LukasTy

Is it blocking you, or can you wait for the next release this Thursday? 🤔

No problem, I can wait, thanks for the reply!

import { TreeItem2DragAndDropOverlay } from '@mui/x-tree-view-pro';

I tried, but got

image Using latest version image

kzimins-arvatosystems avatar Oct 28 '24 08:10 kzimins-arvatosystems

I tried, but got

Once again, I'm sorry for causing confusion in this transition state, where we are preparing the master branch for v8. The renamed TreeItemDragAndDropOverlay is exported from @mui/x-tree-view-pro: https://github.com/mui/mui-x/blob/4c6b35fa8d8d53231c1524fa6fae8194bb9a9e76/packages/x-tree-view-pro/src/index.ts#L11

@flaviendelangle have we forgotten to export TreeItem2DrangAndDropOverlay from the pro package? Should we fix it for v7? 🤔

LukasTy avatar Oct 28 '24 09:10 LukasTy

Sure We need to fix 1-2 things regarding doc gen but it's totally doable

flaviendelangle avatar Oct 28 '24 09:10 flaviendelangle

We need to fix 1-2 things regarding doc gen but it's totally doable

Will you take up this effort? Or should I do it?

LukasTy avatar Oct 28 '24 09:10 LukasTy

I can take care of it if you want

flaviendelangle avatar Oct 28 '24 10:10 flaviendelangle