mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[code-infra] `vitest` browser & jsdom modes

Open JCQuintas opened this issue 1 year ago • 9 comments

Related https://github.com/mui/material-ui/pull/43625

Minimal changes to have charts tests working in browser mode Charts are the smallest test suit though

Help toward https://github.com/mui/mui-public/issues/170.

Currently ignoring DateFnsV3 adapter tests in the browser due to https://github.com/vitest-dev/vitest/issues/6483 they work normally in jsdom though.

Running tests

# all
pnpm vitest

# browser
pnpm vitest --project "browser/*"

# jsdom
pnpm vitest --project "jsdom/*"

JCQuintas avatar Sep 05 '24 18:09 JCQuintas

Deploy preview: https://deploy-preview-14508--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against 73c6a590eaa4bee4b7b1dd5951761d3316271b46

mui-bot avatar Sep 05 '24 23:09 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 09 '24 10:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 11 '24 09:09 github-actions[bot]

@LukasTy @flaviendelangle @noraleonte @arthurbalduini I think I've fixed most of the issues with date-pickers in vitest that I could without going super deep on how everything works 😅

I now need some help with understanding the current errors, and possible ideas on how to fix them.

You can check the current failing tests here: Vitest Tests (jsdom) Vitest Tests (browser)

JCQuintas avatar Sep 11 '24 16:09 JCQuintas

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 19 '24 10:09 github-actions[bot]

@LukasTy had to move away from global overrides in favour of vi.mock because the later works correctly and with minimal required changes in both jsdom and browser. We just have to mock the mock function when running in mocha 😅

Changes are here: https://github.com/mui/mui-x/pull/14508/commits/2d5d395c26c9842a9014b205205699d55e2f554f

JCQuintas avatar Oct 08 '24 14:10 JCQuintas

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 11 '24 22:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 14 '24 12:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 16 '24 10:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 06 '24 16:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 06 '24 17:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 07 '24 08:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 15 '24 14:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 18 '24 07:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 20 '24 16:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 22 '24 11:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 02 '24 16:12 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 03 '24 11:12 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 05 '25 04:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 07 '25 14:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 08 '25 15:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 15 '25 15:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 20 '25 12:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 20 '25 13:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 20 '25 13:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 31 '25 22:01 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 04 '25 19:02 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 14 '25 06:02 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 16 '25 10:02 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 20 '25 15:02 github-actions[bot]