mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[DataGrid] Row spanning

Open MBilalShafi opened this issue 1 year ago • 3 comments

🚧 Work in Progress 🚧

Resolves #207

Based on https://www.notion.so/mui-org/xGrid-Row-Spanning-b178fd43907146799eb7a57d9330b68b?pvs=4#160e28c1b4b247d7befe0cbf44acd475

WIP Preview: https://deploy-preview-14124--material-ui-x.netlify.app/x/react-data-grid/row-spanning/

Todos

  • [x] Fix dark mode
  • [x] Recompute on filter
  • [x] Fix keyboard navigation
    • [x] Basic keyboard navigation
    • [x] With column spanning
  • [x] Add support for colDef.valueGetter
  • [x] Add new colDef.colSpanValueGetter for custom use-cases
  • [x] Fix column resize
  • [x] Accessibility improvements
  • [ ] Support virtualization
  • [ ] Optimize performance
  • [ ] Test coverage
  • [x] Behavior with editing, should editing a spanned cell update all the associated values, how does a colSpan do?

Follow-up Todos

  • [ ] Make the Grid remember the last horizontal rowIndex. https://github.com/mui/mui-x/pull/14124#discussion_r1725397414

MBilalShafi avatar Aug 06 '24 11:08 MBilalShafi

Deploy preview: https://deploy-preview-14124--material-ui-x.netlify.app/

Updated pages:

Generated by :no_entry_sign: dangerJS against 70316348e952d5dedb8c92502df73da96599bf7c

mui-bot avatar Aug 06 '24 11:08 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 13 '24 12:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 29 '24 08:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 16 '24 07:09 github-actions[bot]

@alelthomas Can you review the docs in this PR? Thanks!

cherniavskii avatar Sep 16 '24 12:09 cherniavskii

@MBilalShafi when is the final release of row spanning on the library expected ?

Jcronoxer avatar Sep 17 '24 09:09 Jcronoxer

Additional points for the follow-up section

  • row selection with row spanning
  • cell selection with row spanning

arminmeh avatar Sep 18 '24 12:09 arminmeh

  • row selection with row spanning
  • cell selection with row spanning

In my initial testing, the basic cell selection worked fine, did you spot any specific interaction not properly working? Regarding row selection, I'm not sure tbh if it makes much sense when row spanning is on. IMO we could wait for some feedback to validate if the row selection is actually relevant with the row-spanning feature. Wdyt?

MBilalShafi avatar Sep 18 '24 19:09 MBilalShafi

@MBilalShafi when is the final release of row spanning on the library expected ?

It should be released this week or coming week.

MBilalShafi avatar Sep 18 '24 19:09 MBilalShafi

In my initial testing, the basic cell selection worked fine, did you spot any specific interaction not properly working?

Did not test it. I meant more to validate that we want it to behave the way it is (even if it means it can't be used together)

arminmeh avatar Sep 18 '24 21:09 arminmeh

Hello, can you merge this feature to the v5 version of MUI? Have you tested if export to excel works properly?

tomekxoxo avatar Oct 10 '24 08:10 tomekxoxo

Hey @tomekxoxo,

We only backport critical bug fixes to the previous major versions, I'd suggest you to consider upgrading to a new major.

We have the migration guides available for every major release upgrade. Some of the changes could even be automatically applied using codemods.

Here are the migration guides: v5 -> v6 migration: mui.com/x/migration/migration-data-grid-v5 v6 -> v7 migration: mui.com/x/migration/migration-data-grid-v6

Have you tested if export to excel works properly

I don't think the row spanning is integrated with Excel export as of now.

MBilalShafi avatar Oct 10 '24 11:10 MBilalShafi