mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[DataGrid] Expandable rows not accessible

Open arminmeh opened this issue 1 year ago • 1 comments

Fixes #10032

Used this as a reference https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/examples/treegrid-1/

Also fixes the issue with the value of aria-rowcount as it was not updated after filtering https://github.com/w3c/aria-practices/issues/465

arminmeh avatar Jun 25 '24 13:06 arminmeh

Deploy preview: https://deploy-preview-13623--material-ui-x.netlify.app/

Updated pages:

Generated by :no_entry_sign: dangerJS against 4f48e0617f27ba616a3487d922f31b755b31bfb3

mui-bot avatar Jun 25 '24 13:06 mui-bot

As the original poster of #10032, I just want to thank you for taking this on!

I had a look at the preview the bot posted and it looks good to me! It has all the attributes I'd expect and the numbers are right.

Thanks again,

Armand

ArmandRedgate avatar Jul 04 '24 12:07 ArmandRedgate

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 30 '24 22:07 github-actions[bot]

@arminmeh Can I use this PR to investigate the failing Netlify deployment issue? I'll be pushing commits to your branch if you don't mind it. (I tried reproducing it in separate PRs, but deployments worked just fine 😅)

cherniavskii avatar Aug 02 '24 18:08 cherniavskii

@arminmeh Can I use this PR to investigate the failing Netlify deployment issue? I'll be pushing commits to your branch if you don't mind it. (I tried reproducing it in separate PRs, but deployments worked just fine 😅)

@cherniavskii go ahead Just a heads up. I have pushed another commit after your comment

arminmeh avatar Aug 02 '24 18:08 arminmeh