mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard
verified publisher icon mui

[test] Use test-utils from npm

Open michaldudak opened this issue 1 year ago • 1 comments

michaldudak avatar Apr 23 '24 12:04 michaldudak

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 24 '24 15:04 github-actions[bot]

Deploy preview: https://deploy-preview-12880--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against b45fcc3b6f1517eaf419bd1ef327d3c258a994d1

mui-bot avatar May 27 '24 10:05 mui-bot

The failing tests are most likely not related to this PR, as they also fail when the monorepo is updated to next (https://github.com/mui/mui-x/pull/13086). The out-of-memory error on CI is a bit worrying, though.

I'd appreciate any assistance with these.

michaldudak avatar May 27 '24 15:05 michaldudak

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 28 '24 14:05 github-actions[bot]

It's clear that the explicit memory limit increase is needed as before it the CPU is pegged doing too much GC. 🙈

Before

Screenshot 2024-05-29 at 09 03 34

After

Screenshot 2024-05-29 at 09 05 37

LukasTy avatar May 29 '24 06:05 LukasTy

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 29 '24 07:05 github-actions[bot]

https://github.com/mui/material-ui/pull/41177 has been merged and @mui/internal-test-utils is published to npm with version 1.0.0-dev.20240529-082515-213b5e33ab

michaldudak avatar May 29 '24 08:05 michaldudak

Do you have any idea why argos reacted like there is no reference build and treats all screenshots as new? 🤔 🤷

It looks like an issue on Argos' side. I started seeing it in other PRs as well.

michaldudak avatar May 29 '24 10:05 michaldudak