mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[data grid] Demo LazyLoadingGrid crashes in docs

Open PontusAxelsson opened this issue 1 year ago β€’ 13 comments

Steps to reproduce

  1. Visit https://next.mui.com/x/react-data-grid/row-updates/#lazy-loading
  2. ??
  3. demo LazyLoadingGrid crashes

Your environment

Tech Version
Version v7.0.0-beta.0
Netlify deploy https://65b76b6a52f53800081426d7--material-ui-x.netlify.app
Browser Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Search keywords:

PontusAxelsson avatar Jan 30 '24 14:01 PontusAxelsson

I was looking into these issue, and the easy way to fix it is to add conditional operator here but it seems something is off with the visibleRows at first its empty which I suppose is correct considering the debounce.

But on closer inspection I found when we keep scrolling the visibleRows count goes to 10000 and we can see a lag in the scroll.

At first it shows no Rows shouldnt it be a loading flag ?

After adding conditional operator this is how it looks: @MBilalShafi is this correct behavior?

https://github.com/mui/mui-x/assets/22376783/d6d03eaa-8bca-46ab-9d3e-ec71bc6934f3

jyash97 avatar Jan 30 '24 15:01 jyash97

Hey @jyash97 and thanks for reporting this. We will have a look into this asap! Thanks again! πŸ™‡πŸΌ

michelengelen avatar Jan 31 '24 09:01 michelengelen

@michelengelen we would like to pick this up

gitstart avatar Feb 01 '24 08:02 gitstart

@michelengelen we would like to pick this up

Hey πŸ‘‹πŸ»

I already started looking into it 2 days back just waiting for confirmation from @michelengelen and team on correct behaviour

jyash97 avatar Feb 01 '24 08:02 jyash97

Hey @jyash97 you can find the correct behavior in the docs for v6: Layout

If you want I can assign this to you to fix it.

michelengelen avatar Feb 01 '24 10:02 michelengelen

@michelengelen sure thing

will take a look at the issue more, any way I can get help from team if needed?

jyash97 avatar Feb 01 '24 13:02 jyash97

definitely ... You can either comment here (or on the PR that you will open) or via our Community Discord

michelengelen avatar Feb 01 '24 14:02 michelengelen

Not sure if we already have an issue for this but this started after the sticky PR (#10059), so it's on my tasklist.

@jyash97 If you want to take this you can open a PR. For the correct behavior compare with the v6 version of the docs.

romgrk avatar Feb 01 '24 20:02 romgrk

Not sure if we already have an issue for this but this started after the sticky PR (https://github.com/mui/mui-x/pull/10059), so it's on my tasklist

yes I was able to find the PR which caused the regression, I havent started fixing it yet to correct behaviour, any suggestions to start with or look for?

jyash97 avatar Feb 01 '24 20:02 jyash97

No I haven't touched that code yet, use the v6 equivalent example as the reference: https://mui.com/x/react-data-grid/row-updates/#lazy-loading

Note that this code is part of the commercial plans, so you'll need to sign the CLA if you open a PR.

romgrk avatar Feb 01 '24 22:02 romgrk

Duplicate of #11784?

oliviertassinari avatar Feb 11 '24 00:02 oliviertassinari

Yes it's a duplicate.

@jyash97 I'll pick this one up on Monday unless you're still interested in submitting a PR.

romgrk avatar Feb 11 '24 01:02 romgrk

Hey @romgrk

Sorry for the delay, but you can go ahead and work on this one, don’t want to block the issue right now as I may not be able to look into the issue this week

jyash97 avatar Feb 11 '24 03:02 jyash97

:warning: This issue has been closed. If you have a similar problem, please open a new issue and provide details about your specific problem. If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @PontusAxelsson? Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

github-actions[bot] avatar Feb 27 '24 17:02 github-actions[bot]