mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[data grid] SingleSelect columns stopped getting the label correctly for "is any of" starting from `7.0.0-alpha.7`

Open rodrigofariow opened this issue 1 year ago • 6 comments

Steps to reproduce

Link to live example: https://next.mui.com/x/react-data-grid/filtering/

You can see it clearly on your demos Steps:

  1. Select "Country" filter
  2. Select "is any of" operator
  3. Select a country

Current behavior

The value is shown on the text input instead of the label:

image

Expected behavior

In https://mui.com/x/react-data-grid/filtering/ (latest 6.x) you have the expected behaviour:

image

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: datagrid single select Order ID: 79531

rodrigofariow avatar Jan 19 '24 16:01 rodrigofariow

Thanks @rodrigofariow for raising this issue with us. 🙇🏼 We will certainly have a look at this.

@cherniavskii since this seems like a small regression could it be a "good first issue"?

michelengelen avatar Jan 22 '24 10:01 michelengelen

@michelengelen Sure, why not

cherniavskii avatar Jan 22 '24 11:01 cherniavskii

The regression is most probably coming from https://github.com/mui/mui-x/pull/11330

cherniavskii avatar Jan 22 '24 11:01 cherniavskii

@michelengelen @cherniavskii we would like to pick this up

gitstart avatar Feb 05 '24 08:02 gitstart

Any news @cherniavskii @michelengelen ?

In understand it's considered a small regression but it's a regression that is preventing us from updating to latest alpha versions and incrementally deal with breaking changes.

rodrigofariow avatar Feb 12 '24 10:02 rodrigofariow

@rodrigofariow there is a PR currently open for this. We just did not have the time to look at it yet. I will see it through, ok?

michelengelen avatar Feb 15 '24 09:02 michelengelen

:warning: This issue has been closed. If you have a similar problem, please open a new issue and provide details about your specific problem. If you can provide additional information related to this topic that could help future readers, please feel free to leave a comment.

How did we do @rodrigofariow? Your experience with our support team matters to us. If you have a moment, please share your thoughts through our brief survey.

github-actions[bot] avatar Feb 19 '24 14:02 github-actions[bot]

@rodrigofariow the PR just got merged, so you can expect the changes to hit the new version by the end of the week! :shipit:

michelengelen avatar Feb 19 '24 14:02 michelengelen