mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[MUIX-11171] - onRowEditStop not called when blurring the row from a non-editable cell

Open gitstart opened this issue 1 year ago • 7 comments

Description

Update implementation to ensure that onRowEditStop is triggered when user clicks on an uneditable cell after editing a cell on same row.

https://www.loom.com/share/911cef0d17f5442794ee8e71d80b650e

Fixes #11171


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

gitstart avatar Dec 11 '23 14:12 gitstart

@Janpot @michelengelen this PR is ready for review

gitstart avatar Dec 11 '23 15:12 gitstart

Deploy preview: https://deploy-preview-11377--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against aa28267958de67f36de518782bb7e5936c6be65a

mui-bot avatar Dec 11 '23 15:12 mui-bot

Thanks @gitstart ... could you first make sure that the CI checks are all green? Thanks again!! 🙇🏼

michelengelen avatar Dec 11 '23 15:12 michelengelen

Hi @gitstart I think you might have obscured the gitlog with 83b07a5. Could you try a hard reset and force push to 6d13c03.

on your current branch do this.

git reset --hard 6d13c038f2c9316fcca22d603f0a85858b1697bc;
git push --force;

This will reset the branch to the commit that had all the valid changes. After that try merging upstream/next and push that.

If you need more help please feel free to tag me.

michelengelen avatar Dec 12 '23 08:12 michelengelen

To avoid this from regressing again in the future, do you see an opportunity for adding an automated test that covers this behavior?

Janpot avatar Dec 12 '23 10:12 Janpot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 18 '23 09:12 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 07 '24 10:02 github-actions[bot]

To avoid this from regressing again in the future, do you see an opportunity for adding an automated test that covers this behavior?

@gitstart gentle ping! ^^

michelengelen avatar Feb 20 '24 14:02 michelengelen

Hi @michelengelen, apologies for the delay in implementing this feedback, this is due to some internal resource shuffling on our end. However, we will attend to this as soon as we are able, thanks.

gitstart avatar Feb 23 '24 18:02 gitstart

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 25 '24 01:02 github-actions[bot]