mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard
verified publisher icon mui

[DataGrid] Added baseTooltip to GridColumnHeaderSortIcon.tsx

Open julius0205 opened this issue 2 years ago • 6 comments

GridColumnHeaderSortIcon had a default browser tooltip. I added the baseTooltip so it has the same appearance.

julius0205 avatar Dec 08 '23 07:12 julius0205

Deploy preview: https://deploy-preview-11349--material-ui-x.netlify.app/

Generated by :no_entry_sign: dangerJS against f0a94946ea637f50b2c0757262e0740df60dacc5

mui-bot avatar Dec 08 '23 07:12 mui-bot

I noticed that the browser tooltip is still shown additionally. I'll still fix that

julius0205 avatar Dec 08 '23 07:12 julius0205

@julius0205 could you please fix the CI errors? Thanks!

michelengelen avatar Jan 02 '24 10:01 michelengelen

@julius0205 could you please fix the CI errors? Thanks!

Will take a closer look at it. No clue right now why it failed

julius0205 avatar Jan 31 '24 14:01 julius0205

Send me a request for review again when the test are passing, missed the last notification.

romgrk avatar Jan 31 '24 22:01 romgrk

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 07 '24 10:02 github-actions[bot]