mui-x
mui-x copied to clipboard
[charts] Add a grid component
Fix #10158
For documentation, I went with a page per chart linking to a longer explanation in the axis page.
Demos
Deploy preview: https://deploy-preview-11034--material-ui-x.netlify.app/
Updated pages:
- docs/data/charts/axis/axis.md
- docs/data/charts/bars/bars.md
- docs/data/charts/composition/composition.md
- docs/data/charts/lines/lines.md
- docs/data/charts/scatter/scatter.md
Generated by :no_entry_sign: dangerJS against 8da8ea15cbbfdc949beb2c4cb425072ddb45f26e
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
About extra points
Have you considered the option/need to have conditional grid color styling? Wouldn't it be problem adding it in given the current API?
I don't see issues with the current API. The easies might be to put this color in the axis config, and add option to say if it applies to the tick label, the tick, the grid line
Should we add the support for
themeAugmentation
? 🤔
I always forget this aspect 🙃