mui-toolpad icon indicating copy to clipboard operation
mui-toolpad copied to clipboard

Disable binding for layout props

Open apedroferreira opened this issue 2 years ago • 3 comments

Disable bindings for layout props, following the discussion here: https://github.com/mui/mui-toolpad/pull/804

I decided to keep the underlying infrastructure for layout bindings just in case we still want it in the future.

Screen Shot 2022-08-26 at 17 47 52

apedroferreira avatar Aug 26 '22 16:08 apedroferreira

Your Render PR Server URL is https://toolpad-pr-862.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cc4fj0arrk0482n4m7ng.

render[bot] avatar Aug 26 '22 16:08 render[bot]

This will conflict with changes I'm making in https://github.com/mui/mui-toolpad/pull/838/files#diff-ec80be28f55d9a65ffd34db07be05d96cde782bcd9ace685dc77515e840cfb91L65 I believe disabled should just mean disabling the whole control.

Janpot avatar Aug 29 '22 08:08 Janpot

This will conflict with changes I'm making in https://github.com/mui/mui-toolpad/pull/838/files#diff-ec80be28f55d9a65ffd34db07be05d96cde782bcd9ace685dc77515e840cfb91L65 I believe disabled should just mean disabling the whole control.

ok, no rush to merge this one for me so we can merge yours first and then i can see how to make my PR work with the new changes

apedroferreira avatar Aug 29 '22 15:08 apedroferreira

Your Render PR Server URL is https://toolpad-pr-862.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cc8blikgqg45uliu6k00.

render[bot] avatar Sep 01 '22 13:09 render[bot]

This will conflict with changes I'm making in https://github.com/mui/mui-toolpad/pull/838/files#diff-ec80be28f55d9a65ffd34db07be05d96cde782bcd9ace685dc77515e840cfb91L65 I believe disabled should just mean disabling the whole control.

I've updated this PR according to these changes.

apedroferreira avatar Sep 01 '22 14:09 apedroferreira

Your Render PR Server URL is https://toolpad-pr-862.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ccb2aaarrk01l9fffdgg.

render[bot] avatar Sep 05 '22 16:09 render[bot]