mui-toolpad icon indicating copy to clipboard operation
mui-toolpad copied to clipboard

Published 20 hours ago • verified publisher icon mui

Support Tabs component

Open prakhargupta1 opened this issue 3 years ago • 5 comments

Duplicates

  • [X] I have searched the existing issues

Latest version

  • [X] I have tested the latest version

Summary 💡

Currently, Toolpad supports Tabs. Tabs are basically sub-pages. This issue is about Tabbed containers. Screenshot 2023-05-25 at 12 24 55 PM

https://mui.com/material-ui/react-tabs/

One of: https://github.com/mui/mui-toolpad/issues/78

prakhargupta1 avatar Aug 05 '22 17:08 prakhargupta1

@prakhargupta1 can you confirm if I understand correctly that we want something ala Tabbed container that retool offers? CleanShot 2023-01-02 at 15 21 26@2x

CleanShot 2023-01-02 at 15 21 59@2x

There is also Tabs component which allows controlling other components via special configuration CleanShot 2023-01-02 at 15 23 34@2x

Should we implement one, the other or both?

bytasv avatar Jan 02 '23 13:01 bytasv

We should do Tabbed containers.
Example from appsmith here

prakhargupta1 avatar Jan 02 '23 14:01 prakhargupta1

Let's leave this ussue open for real tabbed containers

Janpot avatar Jan 17 '23 09:01 Janpot

@Janpot

Today I doved into this issue. Tabs can only receive only one children property. my suggestion is change children into a type of array.

JerryWu1234 avatar Oct 10 '23 14:10 JerryWu1234

@Janpot

Today I doved into this issue. Tabs can only receive only one children property. my suggestion is change children into a type of array.

An array of layoutSlot props might work? But not sure if there would be any obstacles that could be complicated to deal with.

apedroferreira avatar Oct 10 '23 15:10 apedroferreira