mui-toolpad icon indicating copy to clipboard operation
mui-toolpad copied to clipboard

WIP: Rest datasource configure body

Open Janpot opened this issue 1 year ago • 2 comments

  • [ ] raw body, with selectable content type
  • [ ] x-www-form-urlencoded

Fixes https://github.com/mui/mui-toolpad/issues/850

Janpot avatar Aug 02 '22 09:08 Janpot

Your Render PR Server URL is https://toolpad-pr-721.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cbkev84gqg48i38bisdg.

render[bot] avatar Aug 02 '22 09:08 render[bot]

Your Render PR Server URL is https://toolpad-pr-721.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cbqag1pa6gdkkqls4isg.

render[bot] avatar Aug 11 '22 06:08 render[bot]

Your Render PR Server URL is https://toolpad-pr-721.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cc8ssula499fvmbkjr8g.

render[bot] avatar Sep 02 '22 09:09 render[bot]

cool! a couple questions/thoughts:

  • i don't know what the "Parameters" below are. could they be included with those tab options if it makes sense?
  • the "transform" functionality is logically a bit different to the other tabs, as it's not something as inherent to the request itself. i wonder if we should separate it somehow? but i also don't dislike it being there in a tab, seems easy to use

apedroferreira avatar Sep 05 '22 16:09 apedroferreira

i don't know what the "Parameters" below are. could they be included with those tab options if it makes sense?

It's parameters to the datasource query itself. this is where you can bind state of the page, which is usable inside of the query bindings. I moved it to this place because it's the same location as in the function and postgresql datasources.

Janpot avatar Sep 05 '22 16:09 Janpot

i don't know what the "Parameters" below are. could they be included with those tab options if it makes sense?

It's parameters to the datasource query itself. this is where you can bind state of the page, which is usable inside of the query bindings. I moved it to this place because it's the same location as in the function and postgresql datasources.

ah i see, makes sense to have them outside the tabs then

apedroferreira avatar Sep 05 '22 16:09 apedroferreira