mui-toolpad icon indicating copy to clipboard operation
mui-toolpad copied to clipboard

[account] [docs] Add `<Account />` in `sidebarFooter`

Open bharatkashyap opened this issue 1 year ago • 1 comments

  • Closes #4102

Summary of grooming discussion

Props:

  • No need to add a hideToolbarAccount prop, users can pass a component which returns null into the toolbarAccount slot when using <Account /> inside the sidebar footer

Slots:

  • button => default = account details (condensed)
  • popup => header + content + footer

export composable components:

  • popup header => default contains account details (extended)
  • popup content
  • popup footer => default contains signout button
  • account details (with variant condensed/extended)

=> for the sidebar version =

  • slot button filled with account details (extended)
  • slot popup filled with content + footer

scenarios:

  • I want to add buttons in the footer actions
  • I want to add tenant switcher in content
  • I want extra information in the header
    • I'm using the extended variant (do you want to change the button as well?)
    • I'm using the condensed variant

bharatkashyap avatar Oct 13 '24 12:10 bharatkashyap

Feel free to remind me to review this one once the others are merged!

apedroferreira avatar Oct 22 '24 16:10 apedroferreira

I am not sure if the following has been addressed in this pull request, but there appears to be a small space on the far right when the Avatar is placed in the SidebarFooter, which is probably due to the flex styling and ideally should not be present.

image

aress31 avatar Oct 30 '24 11:10 aress31

I am not sure if the following has been addressed in this pull request, but there appears to be a small space on the far right when the Avatar is placed in the SidebarFooter, which is probably due to the flex styling and ideally should not be present.

Gets addressed in this PR: Screenshot 2024-10-31 at 5 16 40 PM

bharatkashyap avatar Oct 31 '24 11:10 bharatkashyap

Feel free to remind me to review this one once the others are merged!

Should be ready to review now!

bharatkashyap avatar Oct 31 '24 12:10 bharatkashyap