[icons] Bring back icon testid
Avoid split brain between dev and production. It's too confusing. This brings back the testid, but allows for removing it with property legacyTestid. We can invert the default in v8.
Use the theme defaultProps to turn off this option globally:
const theme = createTheme({
components: {
SvgIcon: {
defaultProps: {
legacyTestid: false,
},
},
},
});
Plan:
- v7.x: introduce the
legacyTestidprop with defaulttrueto avoid breaking change. - v8.0: make it default to
false, the user must always explicitly turn it on in any environment.
Netlify deploy preview
Bundle size report
| Bundle | Parsed Size | Gzip Size |
|---|---|---|
| @mui/material | 🔺+455B(+0.09%) | 🔺+233B(+0.15%) |
| @mui/lab | 🔺+106B(+0.08%) | 🔺+51B(+0.13%) |
| @mui/system | 0B(0.00%) | 0B(0.00%) |
| @mui/utils | 0B(0.00%) | 0B(0.00%) |
Generated by :no_entry_sign: dangerJS against fb62bf1d742289e11e4e4bcabe8a7d5538074abb
@Janpot We just updated to V7 and would love to have this merged. Is there any ETA :)?
@Janpot would love to have this merged too. This in the only point missing to migrate from V6 to V7. Our big E2E suites are breaking due this.
Any info on this issue ? It's break auto-test on our apps to