material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui][Chip] Fix adornments misaligned `RTL`

Open solomonalem opened this issue 11 months ago • 4 comments

Closes: 45193

Local Demo

  • Used createTheme to create thertldirection to test it locally
  • The changes will not change existing (ltr) implementation
Screenshot 2025-02-16 at 11 23 53 PM

solomonalem avatar Feb 17 '25 08:02 solomonalem

@DiegoAndai this is for https://github.com/mui/material-ui/issues/45193

solomonalem avatar Feb 17 '25 08:02 solomonalem

Netlify deploy preview

https://deploy-preview-45330--material-ui.netlify.app/

@material-ui/core: parsed: +0.07% , gzip: +0.02% Autocomplete: parsed: +0.25% , gzip: +0.06% Chip: parsed: +0.40% , gzip: +0.08%

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 2903c113310020dceb3c3e935da81e0927ca052e

mui-bot avatar Feb 18 '25 19:02 mui-bot

@DiegoAndai

  1. How did you implement RTL? Which option did you use—createTheme or including it in index.html? I'm asking because the component expects the direction to come from the theme. If you've applied RTL differently, we can account for those cases as well.

  2. I'll take care of that.

solomonalem avatar Feb 18 '25 20:02 solomonalem

Hey @solomonalem!

  1. The link I shared uses the docs' RTL implementation, which is defined here. It set's the direction on createTheme (reference) as well as the body's dir (reference)

You can test this locally by running pnpm docs:dev and visiting localhost:3000

DiegoAndai avatar Feb 26 '25 20:02 DiegoAndai