material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[code-infra] Widen eslint file patterns

Open Janpot opened this issue 1 year ago • 1 comments

Widen javascript/typescript rules to all possible extensions. Avoids situations like https://github.com/mui/material-ui/pull/44143#discussion_r1804939744

Question for @mui/docs-infra: what with material-ui/no-hardcoded-labels, it applies only to js files and in many ts files there are violations. Should we fix those cases? Or remove the rule altogether?

Janpot avatar Oct 18 '24 09:10 Janpot

Netlify deploy preview

https://deploy-preview-44148--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against afce05657477ff33e36bf045f9bb7f23bef9e06f

mui-bot avatar Oct 18 '24 09:10 mui-bot

Question for @mui/docs-infra: what with material-ui/no-hardcoded-labels, it applies only to js files and in many ts files there are violations. Should we fix those cases? Or remove the rule altogether?

I think it's for enforcing translation of docs component which were initially only written in JS.

Could you open a distinct PR to enable it also on ts files. I will give a look to fix what's needed

alexfauquette avatar Oct 20 '24 07:10 alexfauquette