material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Dialog] Add the aria-modal="true" by default

Open mnajdova opened this issue 1 year ago • 1 comments

The Dialog component is implemented as a modal dialog, but it was missing the aria-modal="true". This PR adds it by default, but also adds the option for people to remove it if for some reason they need to override it. This makes the component compatible with SC 4.1.2

mnajdova avatar Oct 16 '24 08:10 mnajdova

Netlify deploy preview

https://deploy-preview-44118--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 6eeed6009889093d9e81316a8fdbaf079e5dc664

mui-bot avatar Oct 16 '24 09:10 mui-bot

Can we please already test it somewhere? Thanks. :)

abdermaiza avatar Oct 22 '24 09:10 abdermaiza

@abdermaiza v6.1.5 has just been released and includes this improvement

aarongarciah avatar Oct 22 '24 11:10 aarongarciah

It seems good, now !

abdermaiza avatar Oct 22 '24 12:10 abdermaiza