material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[docs] Remove HighlightedCode max-width

Open Janpot opened this issue 1 year ago • 2 comments

This messes up a bit the copy button positioning: https://app.argos-ci.com/mui/material-ui/builds/31842/107814670

Not sure why it's there. Removing to see if I can find something breaking. I can't find an instance of this component where this CSS can have an impact 🤔

Janpot avatar Sep 12 '24 14:09 Janpot

Netlify deploy preview

https://deploy-preview-43731--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against 5e4c4a5b9620940524106f6b48311e665bb05ca1

mui-bot avatar Sep 12 '24 14:09 mui-bot

This was needed to fix mobile overflow. I think to check that the initial cases are not broken.

oliviertassinari avatar Sep 13 '24 10:09 oliviertassinari

This was needed to fix mobile overflow. I think to check that the initial cases are not broken.

Do you remember which use-case this was fixing? I've been looking around at a bunch of code blocks and I can't figure out what this is trying to achieve. Seems to have initially been added in https://github.com/mui/material-ui/pull/27488.

Opening a separate ticket for some other issues I noticed.

Janpot avatar Sep 23 '24 07:09 Janpot

The origin seems to be #20108. A reproduction of the bug: https://v4.mui.com/blog/march-2019-update/.

Ok, it seems fine: https://deploy-preview-43731--material-ui.netlify.app/blog/march-2019-update/.

oliviertassinari avatar Oct 06 '24 21:10 oliviertassinari

What about doing the same modification to the MarkdownElement.tsx file?

At least in screenshots that seems to fix a few more things: https://app.argos-ci.com/mui/material-ui/builds/32870/113602375

Can't find any regressions on pages that use it

Janpot avatar Oct 14 '24 15:10 Janpot