material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[docs] Rename jsx-runtime in `window` object

Open Vxee opened this issue 1 year ago • 3 comments

Vxee avatar Sep 07 '24 13:09 Vxee

Netlify deploy preview

https://deploy-preview-43639--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against 78b9c56fbccd2df5d4ebedcea84dc246b68df999

mui-bot avatar Sep 07 '24 13:09 mui-bot

@alexfauquette Please help to merge it when you are available, thanks.

Vxee avatar Sep 11 '24 06:09 Vxee

That's a breaking change. Even if it's docs, I'm not in favor of adding a breaking change for the only purpose of renaming stuff

alexfauquette avatar Sep 11 '24 08:09 alexfauquette

@alexfauquette I know your concern. This function is created by me. We haven't mentioned this in docs site. So I think it is low impact to rename. I rename it because I use Vite to build the js chunk, I specify the name as jsx, but finally it uses jsxRuntime. So I want to change it and make it easier for developers to integrate. Now my solution is to modify the file after finishing the build.

Vxee avatar Sep 18 '24 03:09 Vxee

@alexfauquette @siriwatknp Can you take a look? Thanks.

Vxee avatar Sep 26 '24 08:09 Vxee

Don't need to rename it, can control in our build script.

Vxee avatar Oct 10 '24 03:10 Vxee