material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[docs] Revert icon search virtualization

Open Janpot opened this issue 1 year ago • 3 comments

Revert icons page back to use deferred value only (as per https://github.com/mui/material-ui/pull/41330#issuecomment-1997454243)

See https://github.com/mui/material-ui/pull/41330#issuecomment-2323517472

After: https://deploy-preview-43569--material-ui.netlify.app/material-ui/material-icons/

Janpot avatar Sep 02 '24 07:09 Janpot

Netlify deploy preview

https://deploy-preview-43569--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against a49d647aa0c3d65b8d92b8807e973fcaea9df995

mui-bot avatar Sep 02 '24 07:09 mui-bot

You can compare the input responsiveness with https://deploy-preview-43582--material-ui.netlify.app/material-ui/material-icons/ where I removed the deferred values. You don't even need to throttle CPU to notice the difference. Just type "a" and then backspace

but instead, once the full list of icons starts rendering, it never gets interrupted:

I'm not sure I follow. How do you know it never gets interrupted just by looking at the UI?

Janpot avatar Sep 03 '24 09:09 Janpot

@Janpot Oh, ok, strange. I see it behaving as expected on the PR preview (prod mode) but not in dev mode.

All the feedback that I left seems handled here. This looks like a clear step forward, I think it's much better 👍.

I used the opportunity to remove a lot of <div>: a7418a14815f07b64ff3b01b0eab45577bfd4125. Before: https://pagespeed.web.dev/analysis/https-deploy-preview-43168--material-ui-netlify-app-material-ui-material-icons/zrq6w27l77?form_factor=desktop SCR-20240913-dcpa

After: https://pagespeed.web.dev/analysis/https-deploy-preview-43569--material-ui-netlify-app-material-ui-material-icons/ffwxi8dwji?form_factor=desktop SCR-20240913-dbwb

oliviertassinari avatar Sep 13 '24 00:09 oliviertassinari