material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard
verified publisher icon mui

[base-ui][mui-system] Fix "useId" & "useSyncExternalStore" imports to not be statically analysable

Open yash49 opened this issue 1 year ago • 3 comments

fixes #41190

yash49 avatar Aug 18 '24 12:08 yash49

Netlify deploy preview

https://deploy-preview-43360--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against b3840af957896c700b810412dc715f94b5f026c5

mui-bot avatar Aug 18 '24 12:08 mui-bot

hi @atomiks, can you please review this tiny pr?

yash49 avatar Aug 26 '24 15:08 yash49

Thank you @atomiks for reviewing the PR.

@oliviertassinari / @zannager can we merge this PR ?

yash49 avatar Aug 27 '24 11:08 yash49

I did some clean-up. I think it's ready to be merged?

Looking at the useId inspired me to open https://github.com/mui/base-ui/issues/616.

oliviertassinari avatar Sep 14 '24 23:09 oliviertassinari