material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[core] Fix issues reported by eslint-plugin-react-compiler

Open binsmyth opened this issue 1 year ago • 3 comments

Part of #42564

Sorry for being late to contribute. I changed the codes in these files to remove errors -

  • packages/mui-material/src/Backdrop/Backdrop.js
  • packages/mui-material/src/usePagination/usePagination.test.js
  • packages/mui-material/src/FormControl/FormControl.js While rest of them I put eslint disable comments. Either difficult to change or could break something.

For this package there was two changes didn't realize that the change caused test to not work so undid the changes and added disabled comments

binsmyth avatar Jul 30 '24 09:07 binsmyth

Netlify deploy preview

https://deploy-preview-43117--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against cd0f9fad1256593e65ca5b0fc8ee11c6eb9a818f

mui-bot avatar Jul 30 '24 09:07 mui-bot

@binsmyth there are comments that haven't been addressed (e.g. https://github.com/mui/material-ui/pull/43117/files#r1703678961). Please, go through all of them and reply accordingly before requesting a new review.

aarongarciah avatar Aug 12 '24 10:08 aarongarciah

@aarongarciah Sorry must have missed it.I will check it. thanks

binsmyth avatar Aug 12 '24 10:08 binsmyth