material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[docs] Link Toolpad Core components from Material Ui docs

Open prakhargupta1 opened this issue 1 year ago • 1 comments

prakhargupta1 avatar Jul 23 '24 08:07 prakhargupta1

@Janpot For this issue I tried mentioning Toolpad components in the core docs in this PR. There are rendering issues that needs your inputs.

prakhargupta1 avatar Jul 26 '24 08:07 prakhargupta1

@prakhargupta1 Fixed it but in latest weekly we decided to not add demos to these experimental sections. They could confuse users on the page. Users may not always be reading the text and just see a demo => copy + paste.

Janpot avatar Jul 30 '24 13:07 Janpot

I reworked copy a bit and removed the demos. I left one demo in as sort of a showcase. It doesn't have a preview to not give users the false impression it's part of Material UI. Just as happy to leave it out as well. wdyt?

Janpot avatar Aug 02 '24 07:08 Janpot

I reworked copy a bit and removed the demos. I left one demo in as sort of a showcase. It doesn't have a preview to not give users the false impression it's part of Material UI. Just as happy to leave it out as well. wdyt?

This form looks great to me; I would prefer having them on all components that we're touching, not just the Dialog and AppBar

bharatkashyap avatar Aug 02 '24 07:08 bharatkashyap

I would prefer having them on all components that we're touching

We have it on appbar, drawer, container, breadcrumbs. Essentially the pages for components people would be on when build application layout. I'm not sure it would make sense to put on other component pages.

I don't think we can really properly showcase the imperative APIs without also showing code and I'd like to avoid that. Therefore I propose we leave Dialog/Snackbar as is.

Janpot avatar Aug 02 '24 08:08 Janpot

Couldn't find a reference of adding beta chip in .md files, so simple added (beta) to the title, like it was done here.

Screenshot 2024-08-05 at 8 03 07 PM

prakhargupta1 avatar Aug 05 '24 14:08 prakhargupta1