material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui][TextField] Fix ownerState silent propagation

Open DiegoAndai opened this issue 1 year ago • 2 comments

This is a symptom of https://github.com/mui/material-ui/issues/42184

Introduced due to https://github.com/mui/material-ui/pull/42001 and https://github.com/mui/material-ui/pull/42062 being merged in parallel without testing them together. I think this is why Argos didn't catch it.

Bug

https://next.mui.com/material-ui/react-text-field/

Screenshot 2024-05-22 at 15 48 41 Screenshot 2024-05-22 at 15 48 22

Fix

PR preview: Waiting for PR deploy

Benchmark: https://mui.com/material-ui/react-text-field/

Notes

The TextField's intricate ownerState scheme is hard to track and maintain. There are probably bugs similar to these that we didn't catch.

DiegoAndai avatar May 22 '24 19:05 DiegoAndai

Netlify deploy preview

https://deploy-preview-42345--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 796fd6ea44d4bda874bf23844f50a59fc1910196

mui-bot avatar May 22 '24 19:05 mui-bot

See Argos "failures" for further fixes 😅

DiegoAndai avatar May 22 '24 20:05 DiegoAndai

Closed in favor of https://github.com/mui/material-ui/pull/42358

DiegoAndai avatar May 28 '24 13:05 DiegoAndai