material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui] Remove remaining IE11 code

Open DiegoAndai opened this issue 1 year ago • 1 comments

Material UI portion of https://github.com/mui/material-ui/issues/14420

Remove the remaining IE11-related code from the Material UI package.

DiegoAndai avatar May 17 '24 20:05 DiegoAndai

Netlify deploy preview

https://deploy-preview-42283--material-ui.netlify.app/

@material-ui/core: parsed: -0.22% :heart_eyes:, gzip: -0.29% :heart_eyes: @material-ui/lab: parsed: -0.34% :heart_eyes:, gzip: -0.39% :heart_eyes: TabList: parsed: -1.02% :heart_eyes:, gzip: -0.97% :heart_eyes:

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against 1efe7369e2e42711822e4a564094e9d84d27303f

mui-bot avatar May 17 '24 20:05 mui-bot

On hold: https://github.com/mui/material-ui/pull/42358

DiegoAndai avatar May 23 '24 20:05 DiegoAndai

Doesn't this close https://github.com/mui/material-ui/issues/14420?

Not yet, because there are still some occurrences in other packages and the docs, as you pointed out. I want to handle those separately. This PR only covers Material UI.

DiegoAndai avatar May 27 '24 20:05 DiegoAndai

What do you think about removing this warning? We no longer want to suggest using Material UI version 4.

@ZeeshanTamboli Good catch. I agree; we officially do not support IE, so there is no need for the warning. Implemented.

DiegoAndai avatar May 31 '24 13:05 DiegoAndai

Don't forget all the uses of Array.indexOf('some string') [===|!==] -1 as a substitute for ~Array.filter~ Array.includes.

mbrookes avatar Jun 02 '24 22:06 mbrookes

Don't forget all the uses of Array.indexOf('some string') [===|!==] -1 as a substitute for Array.filter.

@mbrookes, thanks for the callout. Do you remember an example in particular so we can create a separate issue for it?

DiegoAndai avatar Jun 03 '24 16:06 DiegoAndai

Sorry, I meant Array.includes, which IE 11 doesn't support.

These should find the Material-UI specific ones but there are plenty more:

Components Docs

mbrookes avatar Jun 03 '24 19:06 mbrookes