material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui][types] Make slots partial in `CreateSlotsAndSlotProp`type

Open lhilgert9 opened this issue 9 months ago • 2 comments

@DiegoAndai As already discussed in #41875, here is the PR to make the slots in the CreateSlotsAndSlotProps help type partial to avoid possible errors.

lhilgert9 avatar May 01 '24 07:05 lhilgert9

Netlify deploy preview

https://deploy-preview-42077--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against 6165656dd6d4efbad489c5d7e3fbf0264941fd9c

mui-bot avatar May 01 '24 07:05 mui-bot

Thanks for working on this @lhilgert9!

I'm on board with the changes. What do you think, @siriwatknp? Does this make sense to you?

DiegoAndai avatar May 03 '24 16:05 DiegoAndai

@DiegoAndai @siriwatknp What about this one?

lhilgert9 avatar Jul 13 '24 21:07 lhilgert9

@DiegoAndai @siriwatknp Can you review this? The PR has been open for a while.

ZeeshanTamboli avatar Aug 26 '24 06:08 ZeeshanTamboli

@lhilgert9 I'm so sorry for the late reply. The v6 stable release consumed most of my time in the past month.

I'm still on board with this change. What do you think about removing ? for the slots definitions which are now redundant, would you be up to do it in this same PR?

DiegoAndai avatar Aug 30 '24 17:08 DiegoAndai

@DiegoAndai Done🚀 Hope I got them all.

lhilgert9 avatar Aug 31 '24 00:08 lhilgert9