material-ui
material-ui copied to clipboard
mui
[material-ui][Autocomplete] deprecate `*Component` and `*Props` for v6
Part of #41281. @DiegoAndai
The question is whether we should also deprecate the components and componentProps in this PR at the same time, as that wouldn't be much more work.
- [x] I have followed (at least) the PR section of the contributing guide.
Netlify deploy preview
Autocomplete: parsed: +0.73% , gzip: +0.77%
Bundle size report
Details of bundle changes (Toolpad) Details of bundle changes
Generated by :no_entry_sign: dangerJS against d859029465594b06c3962f0687d3c0f2e0cdfe6e
The question is whether we should also deprecate the components and componentProps in this PR at the same time, as that wouldn't be much more work.
Let's do it in a separate follow-up PR to keep things orderly 😊
Requested review from @michaldudak as the owner of the Autocomplete component.
Let's make sure the demos don't reference deprecated props. I found the GitHub label and Virtualize demos still use them.
@michaldudak Should I also change the demos in this PR?
@DiegoAndai I have an idea to improve the CreateSlotsAndSlotProps type by rewriting the slots as Partial:
- slots?: Slots
+ slots?: Partial<Slots>
For example, it happened to me now that I forgot to make the slots optional and that wouldn't happen that way.
Hey @lhilgert9!
Should I also change the demos in this PR?
Yes, please 😊
I have an idea to improve the CreateSlotsAndSlotProps type by rewriting the slots as Partial
That's an interesting proposal 🤔 I think I'm on board with it. If you're up to it, let's open a separate PR for it, as we should update the other occurrences 🙌🏼
Demos are changed by the codemod so it looks like it works on a real example🚀🚀
Let me know if these changes make sense to you and I'll merge 🙌🏼
LGTM Just pushed pnpm docs:api. I have no idea why e2e fails now but I think we can merge the PR.🚀