material-ui
material-ui copied to clipboard
mui
[icons] Add the "Emergency" icon
Steps to reproduce
Link to live example: (required)
Steps: 1. 2. 3.
Current behavior
No response
Expected behavior
No response
Context
No response
Your environment
npx @mui/envinfo
Don't forget to mention which browser you used.
Output from `npx @mui/envinfo` goes here.
Search keywords: emergency, icon
@CelestialWorthy no, this one from Material Icons
https://fonts.google.com/icons?selected=Material+Symbols+Outlined:emergency:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=emergency
What is the naming convention for the icons? I saw that material icons contain svg icons so do i just import it there ?
on another note , do you think it is possible to add car logos as icons ?
@danilo-leal does your PR add the Emergency icon specifically?
https://fonts.google.com/icons?icon.set=Material+Icons&selected=Material+Icons+Outlined:emergency:&icon.query=emergency
@Justin-Luo It should've been added, but looking back again, it doesn't seem like it has 🤔 I've seen other instances (https://github.com/mui/material-ui/issues/39874) where the script to update the Material Icons wasn't picking up every new icon available there. Any pointers @siriwatknp or @michaldudak?
The icon @Justin-Luo linked to is from Material Symbols, not Material Icons. Our library mirrors Material Icons, which doesn't contain the Emergency icon. If you'd like it to, please open an issue in the Material Icons repo.
🤨 The icon he's linking is from Material Icons, though, not from Symbols. That's why I thought it should've been picked up.
https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aemergency%3A
Sorry, I saw just the first link :/ The icons download script has a list of seemingly random exclusions (https://github.com/mui/material-ui/blob/next/packages/mui-icons-material/scripts/download.mjs#L14). I never fully understood the pattern here. I think it's safe to remove the emergency icon from this list and run the scripts again.