material-ui
material-ui copied to clipboard
[material-ui][Button] Add target attribute to types
Fixes https://github.com/mui/material-ui/issues/41452
- [x] I have followed (at least) the PR section of the contributing guide.
Netlify deploy preview
https://deploy-preview-41458--material-ui.netlify.app/
Bundle size report
No bundle size changes (Toolpad) No bundle size changes
Generated by :no_entry_sign: dangerJS against ecda56ba420e8eb82ef3508a71ef989a398b5baf
@KumarNitin19 I've tweaked the tests a bit, thanks for working on this!
@mj12albert Thanks!
I believe the fix here is wrong. The Material UI
Button
component extends fromButtonBase
, which already inherits from native HTMLbutton
ora
elements. And thea
anchor element inherently include thetarget
property.
@ZeeshanTamboli Yes you're right, I think It's a problem with component prop type.
Since this PR is inactive, I am closing it.