material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui][Button] Add target attribute to types

Open KumarNitin19 opened this issue 11 months ago • 3 comments

Fixes https://github.com/mui/material-ui/issues/41452

KumarNitin19 avatar Mar 12 '24 07:03 KumarNitin19

Netlify deploy preview

https://deploy-preview-41458--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against ecda56ba420e8eb82ef3508a71ef989a398b5baf

mui-bot avatar Mar 12 '24 07:03 mui-bot

@KumarNitin19 I've tweaked the tests a bit, thanks for working on this!

@mj12albert Thanks!

KumarNitin19 avatar Mar 18 '24 07:03 KumarNitin19

I believe the fix here is wrong. The Material UI Button component extends from ButtonBase, which already inherits from native HTML button or a elements. And the a anchor element inherently include the target property.

@ZeeshanTamboli Yes you're right, I think It's a problem with component prop type.

KumarNitin19 avatar Apr 27 '24 20:04 KumarNitin19

Since this PR is inactive, I am closing it.

ZeeshanTamboli avatar May 11 '24 08:05 ZeeshanTamboli