material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[website] Add Marblism diamond sponsor

Open rluzists1 opened this issue 1 year ago • 6 comments

https://mui.zendesk.com/agent/tickets/17044

4 locations to check:

  • https://github.com/rluzists1/material-ui/blob/marblism-diamond-sponsorship/README.md#diamond-
  • https://deploy-preview-41097--material-ui.netlify.app/material-ui/discover-more/backers/
  • https://deploy-preview-41097--material-ui.netlify.app/#sponsors

rluzists1 avatar Feb 14 '24 15:02 rluzists1

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against d90fa320600c163849c1439e5f363e996e273a3a

mui-bot avatar Feb 14 '24 15:02 mui-bot

@rluzists1 Please don't use @core, this notifies everyone and subscribe them to future notifications on this PR.

Instead, let's rely on the people responsible or accountable of https://www.notion.so/mui-org/Keep-sponsors-up-to-date-7ebff6991f2946ca853b0e1d3df3a826.

oliviertassinari avatar Feb 14 '24 15:02 oliviertassinari

Please don't use @ core, this notifies everyone.

Quick aside about this: I've added some brief review "etiquette" instructions (that can be enhanced/beefed up) on the Notion GitHub PRs page. I think we can help folks who aren't that familiar with GitHub by writing down more of these "how-to-use" guides about the tools we use! @rluzists1 I wouldn't be surprised if you have just learned about this little instruction now through trial and error, but maybe for future non-devs interacting with code, this can be handy! :)

danilo-leal avatar Feb 14 '24 16:02 danilo-leal

I wouldn't be surprised if you have just learned about this little instruction now through trial and error, but maybe for future non-devs interacting with code, this can be handy! :)

Thanks @danilo-leal :) I'd used the @core for my career page PR so just assumed that was custom; agree having these how-tos is really helpful

rluzists1 avatar Feb 14 '24 16:02 rluzists1

I pushed a fix for a two-year-old bug: https://github.com/mui/material-ui/pull/33528#discussion_r928718156, and increased the pixel ratio to support mobile (usually x3) for the exiting sponsors.

I didn't touch the new one (maybe I should have done this in a separate PR). The image handling of Marblism needs to be fixed though:

  • Missing dark mode
  • Pixelized rendering

oliviertassinari avatar Feb 14 '24 17:02 oliviertassinari

Applied the same changes to the marblism image on backers and READ.me

rluzists1 avatar Feb 14 '24 18:02 rluzists1

Good on my end. I polished the existing sponsors as much as I could

oliviertassinari avatar Feb 17 '24 13:02 oliviertassinari

Still can't seem to get that readme to work, not sure what the issue is? Screenshot 2024-02-19 at 10 06 00

rluzists1 avatar Feb 19 '24 09:02 rluzists1

@rluzists1 It won't work right now since the image you added only lives in your branch. Once your changes are merged to master and the docs site gets the updated code, it'll have the new image and your changes in README will also reflect the image.

brijeshb42 avatar Feb 19 '24 09:02 brijeshb42

Thank you @brijeshb42 that's really helpful, I'll stop stressing about it then!

In that case, all changes on my end are complete/look good; will wait for your review @danilo-leal before merging :)

rluzists1 avatar Feb 19 '24 09:02 rluzists1

Thanks for reviewing @danilo-leal and yes, we have in theory! I've removed other language that referenced it on the site (1/3 slots), although I haven't made changes to the parts of the code that reference it (const maxNumberOfDimaondSponsors = 3 in DiamondSponsors.txt) just yet. Will tackle this if/when we want to add a 4th diamond sponsor.

All good for me to click squash and merge then?

rluzists1 avatar Feb 19 '24 11:02 rluzists1