material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[code-infra] Generalize and publish proptypes generator

Open michaldudak opened this issue 1 year ago • 7 comments

  • Created the new @mui-internal/proptypes-builder package. It was extracted from the existing proptypes generation script and cleaned up to be more self-contained and configurable.
  • Moved TS project related types and functions to @mui-internal/docs-utilities so they can be shared between packages.

This PR is built on top of https://github.com/mui/material-ui/pull/40842 and should be merged after it.

michaldudak avatar Jan 23 '24 09:01 michaldudak

Netlify deploy preview

https://deploy-preview-40757--material-ui.netlify.app/

Bundle size report

Bundle size will be reported once CircleCI build #644182 finishes.

Generated by :no_entry_sign: dangerJS against fefcf518f5d85f856bbc7dd996acd362205654df

mui-bot avatar Jan 23 '24 09:01 mui-bot

Is there an impact on X?

Janpot avatar Jan 24 '24 09:01 Janpot

Yes, I'm working on a PR in X.

michaldudak avatar Jan 24 '24 13:01 michaldudak

X integration PR: https://github.com/mui/mui-x/pull/11801

michaldudak avatar Jan 25 '24 11:01 michaldudak

This is getting too big for a single PR. I'm going to split it into smaller ones.

michaldudak avatar Jan 29 '24 12:01 michaldudak

Here are the extracted bits: https://github.com/mui/material-ui/pull/40842

michaldudak avatar Jan 29 '24 14:01 michaldudak

@michaldudak I'm going through older PRs. Are there any plans to continue this one, or should we close it?

ZeeshanTamboli avatar Nov 06 '25 13:11 ZeeshanTamboli

I don't think so. I hope to get rid of proptypes at some point. Base UI doesn't have them and we haven't heard a single complaint.

michaldudak avatar Nov 14 '25 17:11 michaldudak