material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[material-ui][Button] Deprecate classes for v6

Open sai6855 opened this issue 1 year ago • 6 comments

part of #40417

(Button doesn't have components, componentsProps, *COmponent, *Props) so i think button can be marked as done in original issue, once this is merged)

preview: https://deploy-preview-40675--material-ui.netlify.app/material-ui/api/button/#classes

sai6855 avatar Jan 18 '24 12:01 sai6855

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against ffe5c1e7991418272ef959db101eba4e837ba796

mui-bot avatar Jan 18 '24 12:01 mui-bot

Hey @sai6855! I'm aware of this PR, but we're discussing whether prop default values should have classes: https://github.com/mui/material-ui/issues/40733. Please leave your opinion there if you have one 😊.

So I'll put this on hold until we make a decision. I'll push so we move fast on it.

DiegoAndai avatar Jan 22 '24 13:01 DiegoAndai

Got it!! thanks for the update

sai6855 avatar Jan 22 '24 13:01 sai6855

@DiegoAndai since option 1 is choosen for above RFC, I'm assuming no change is required in this PR

sai6855 avatar Jan 22 '24 17:01 sai6855

@sai6855 correct! No change is required.

We'll keep this PR on hold for a little longer as per this comment: https://github.com/mui/material-ui/issues/40417#issuecomment-1905969569

DiegoAndai avatar Jan 23 '24 12:01 DiegoAndai

Hey @sai6855, we're now unblocked: https://github.com/mui/material-ui/issues/40417#issuecomment-1946344627

DiegoAndai avatar Feb 15 '24 15:02 DiegoAndai