material-ui
material-ui copied to clipboard
[material-ui][Button] Deprecate classes for v6
part of #40417
(Button doesn't have components, componentsProps, *COmponent, *Props) so i think button can be marked as done in original issue, once this is merged)
preview: https://deploy-preview-40675--material-ui.netlify.app/material-ui/api/button/#classes
- [x] I have followed (at least) the PR section of the contributing guide.
Netlify deploy preview
Bundle size report
Details of bundle changes (Toolpad) Details of bundle changes
Generated by :no_entry_sign: dangerJS against ffe5c1e7991418272ef959db101eba4e837ba796
Hey @sai6855! I'm aware of this PR, but we're discussing whether prop default values should have classes: https://github.com/mui/material-ui/issues/40733. Please leave your opinion there if you have one 😊.
So I'll put this on hold until we make a decision. I'll push so we move fast on it.
Got it!! thanks for the update
@DiegoAndai since option 1 is choosen for above RFC, I'm assuming no change is required in this PR
@sai6855 correct! No change is required.
We'll keep this PR on hold for a little longer as per this comment: https://github.com/mui/material-ui/issues/40417#issuecomment-1905969569
Hey @sai6855, we're now unblocked: https://github.com/mui/material-ui/issues/40417#issuecomment-1946344627