material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[TextField] Fix unstable height of memoized multiline TextField component

Open amal-qb opened this issue 1 year ago • 1 comments

Fixes #36866

amal-qb avatar May 02 '23 12:05 amal-qb

Netlify deploy preview

https://deploy-preview-37135--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad) Details of bundle changes

Generated by :no_entry_sign: dangerJS against ccf26d798be44fa45ef65c6ae0233860c3c0cfa0

mui-bot avatar May 02 '23 12:05 mui-bot

@michaldudak Can you please review and merge this PR?

amal-qb avatar May 08 '23 04:05 amal-qb

Hi @michaldudak , Can you review this please?

amal-qb avatar May 23 '23 10:05 amal-qb

The issue is still present (although not as apparent as before). I suggest removing debounce from the handleResize call.

michaldudak avatar Jun 16 '23 12:06 michaldudak

@michaldudak I have removed debounce from handleResize call. Sorry for committing the fix so late.

amal-qb avatar Jul 28 '23 11:07 amal-qb

@michaldudak Can you please review the changes?

amal-qb avatar Aug 08 '23 09:08 amal-qb

@amal-qb Can you please merge with the latest master branch so that all the CI jobs run?

ZeeshanTamboli avatar Aug 10 '23 13:08 ZeeshanTamboli

@ZeeshanTamboli Done

amal-qb avatar Aug 11 '23 10:08 amal-qb

Thanks for the fix!

michaldudak avatar Aug 30 '23 09:08 michaldudak

Test case added in https://github.com/mui/material-ui/pull/38728

oliviertassinari avatar Sep 16 '23 18:09 oliviertassinari