material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Slider] Arrow keys control does not work with float numbers

Open gitstart opened this issue 2 years ago • 6 comments

Resolves Arrow control not working when mark values are float number

closes https://github.com/mui/material-ui/issues/36996

preview: https://codesandbox.io/s/keen-kapitsa-ij9ujr


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

gitstart avatar Apr 28 '23 08:04 gitstart

Netlify deploy preview

https://deploy-preview-37071--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 40ec003df0c5d74c810b1f29f06020a784c260a0

mui-bot avatar Apr 28 '23 08:04 mui-bot

@michaldudak this PR is ready for review

gitstart avatar Apr 28 '23 08:04 gitstart

I just tested this and it looks like it has done the trick. Good Job!

nicoara01 avatar May 01 '23 10:05 nicoara01

I found one issue - when I focus the slider and press the right arrow, the thumb goes to the left initially.

Also, it would be great to have a test that verifies the solution.

michaldudak avatar May 01 '23 19:05 michaldudak

I found one issue - when I focus the slider and press the right arrow, the thumb goes to the left initially.

Also, it would be great to have a test that verifies the solution.

Thanks for the feedback @michaldudak, we are currently implementing your comments. However, we have so far been unable to reproduce the issue in your first paragraph. Would it be possible to provide specific steps to reproduce or perhaps a loom video?

gitstart avatar May 02 '23 11:05 gitstart

I found one issue - when I focus the slider and press the right arrow, the thumb goes to the left initially.

Also, it would be great to have a test that verifies the solution.

Your comment has been addressed @michaldudak, please confirm if this fix solves the problem.

gitstart avatar May 04 '23 08:05 gitstart