material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Slider][Base] Improve logic for displaying value label

Open ZeeshanTamboli opened this issue 3 years ago • 1 comments

There are two things in this PR:

  • [ ] Move the logic of valueLabelDisplay prop to Material UI/Joy UI. To do this, we migrate the Material UI Slider to use useSlider hook. This has the advantage of keeping the Slider's component structure controlled by Material UI and also we are able to have the valueLabelDisplay logic controlled which is not needed in MUI Base due to the point below.
  • [ ] Remove the SliderLabelValueUnstyled component from MUI Base and show the value label by simply hovering on the thumb in SliderUnstyled. Add demos to showcase it. To avoid breaking changes in Material UI, we keep the same component structure like SliderLabelValueUnstyled for the value label.

Closes #35398

ZeeshanTamboli avatar Dec 14 '22 10:12 ZeeshanTamboli

Messages
:book: Netlify deploy preview: https://deploy-preview-35479--material-ui.netlify.app/

@material-ui/core: parsed: -0.16% :heart_eyes:, gzip: -0.19% :heart_eyes: @material-ui/unstyled: parsed: -0.66% :heart_eyes:, gzip: -0.50% :heart_eyes:

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 886803ef0e1b654e94a3763e6e9566d8d9b9221f

mui-bot avatar Dec 14 '22 10:12 mui-bot

As discussed in https://github.com/mui/material-ui/pull/35479#discussion_r1060974938, splitting this PR into two PRs. So closing in favor of https://github.com/mui/material-ui/pull/35770 and https://github.com/ZeeshanTamboli/material-ui/pull/2.

ZeeshanTamboli avatar Jan 09 '23 10:01 ZeeshanTamboli