material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Draft: [Joy] Remove `TextField` component and replace its usage in docs with `FormControl`/`FormLabel`/`Input`

Open hbjORbj opened this issue 3 years ago • 4 comments

Closes https://github.com/mui/material-ui/issues/34176

:warning: This PR can be merged only after Input Documentation PR is merged.

Preview: https://deploy-preview-35462--material-ui.netlify.app/

hbjORbj avatar Dec 13 '22 16:12 hbjORbj

Messages
:book: Netlify deploy preview: https://deploy-preview-35462--material-ui.netlify.app/

@mui/joy: parsed: -0.80% :heart_eyes:, gzip: -0.70% :heart_eyes:

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 67cd5cfa7831bc7e80678980bc2915fbcd2b0685

mui-bot avatar Dec 13 '22 22:12 mui-bot

@hbjORbj Thanks a lot for the PR. One thing that is missing is the doc for the Input at /joy-ui/react-input.

I think the page could have content similar to https://mui.com/joy-ui/react-textarea/.

siriwatknp avatar Dec 14 '22 05:12 siriwatknp

@hbjORbj Thanks a lot for the PR. One thing that is missing is the doc for the Input at /joy-ui/react-input. I think the page could have content similar to https://mui.com/joy-ui/react-textarea/.

Gottcha. I will create a separate PR for better reviewability. We can merge the Input documentation PR first and then merge this one.

hbjORbj avatar Dec 14 '22 11:12 hbjORbj

A note before I forgot it 😅. Please add the _redirects from /joy-ui/react-text-field/ to /joy-ui/react-input/.

siriwatknp avatar Dec 15 '22 14:12 siriwatknp

@hbjORbj Could you update the PR? I think I will try to add a codemod for transforming TextField to Input and then we can merge this PR.

siriwatknp avatar Jan 03 '23 05:01 siriwatknp

@siriwatknp Could you update the PR? I think I will try to add a codemod for transforming TextField to Input and then we can merge this PR.

Done.

I can work on the codemod. Or did you start already?

hbjORbj avatar Jan 03 '23 15:01 hbjORbj

@siriwatknp Could you update the PR? I think I will try to add a codemod for transforming TextField to Input and then we can merge this PR.

Done.

I can work on the codemod. Or did you start already?

I haven't. That'd be great if you could add it.

siriwatknp avatar Jan 03 '23 15:01 siriwatknp

@siriwatknp I haven't. That'd be great if you could add it.

Done

hbjORbj avatar Jan 04 '23 21:01 hbjORbj

@siriwatknp

I think I covered all cases. Happy to get the codemod reviewed at this point.

hbjORbj avatar Jan 07 '23 04:01 hbjORbj