material-ui
material-ui copied to clipboard
[Slider][Base] Convert Slider Base to typescript
Fixes: https://github.com/mui/material-ui/issues/34720
- [x] I have followed (at least) the PR section of the contributing guide.
Messages | |
---|---|
:book: | Netlify deploy preview: https://deploy-preview-35445--material-ui.netlify.app/ |
Generated by :no_entry_sign: dangerJS against 16a378e13da3e358f3dd1378c9ca7b30e39bc21a
@ZeeshanTamboli can you or anyone from team finish review of the PR. previous review came close to being approved
@ZeeshanTamboli updated comments and thanks for review
@sai6855 I just found two more improvements. Once you resolve them, I will re-approve. Thanks.
@ZeeshanTamboli updated code as suggested
Make sure to update with latest master now that https://github.com/mui/material-ui/pull/35564 was merged.
@mnajdova can this be merged, as everything looks good?