material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Modal] Fix can't override Backdrop Props using new Slots API

Open ZeeshanTamboli opened this issue 1 year ago • 2 comments

Fixes #35094

Note that the slotProps prop did not get updated like the componentsProps prop with the PropTypes generation script. I don't know much about that script so if you can point me out where to look at I can take a look.

ZeeshanTamboli avatar Nov 14 '22 07:11 ZeeshanTamboli

Messages
:book: Netlify deploy preview: https://deploy-preview-35140--material-ui.netlify.app/

No bundle size changes

Generated by :no_entry_sign: dangerJS against 469ef4e8c2479d0a52119bf2a69454b861c65312

mui-bot avatar Nov 14 '22 07:11 mui-bot

cc @michaldudak you may want to take a look at this.

mnajdova avatar Dec 13 '22 12:12 mnajdova

@michaldudak Can you take a look?

ZeeshanTamboli avatar Dec 27 '22 13:12 ZeeshanTamboli

The proptypes gerneration script treats slotProps the same way as componentsProps

Yes. But the slotProps proptype had not updated with the script was what I meant. Anyway, ignore this now since the proptypes are not needed to be updated.

ZeeshanTamboli avatar Dec 28 '22 10:12 ZeeshanTamboli

@michaldudak Ready for further review.

ZeeshanTamboli avatar Dec 28 '22 10:12 ZeeshanTamboli