material-ui
material-ui copied to clipboard
[Modal] Convert code to typescript
Thank you for your review, I will work on these on the weekend!
Messages | |
---|---|
:book: | Netlify deploy preview: https://deploy-preview-34793--material-ui.netlify.app/ |
Generated by :no_entry_sign: dangerJS against b511f658aed033071b5892279c006acbd408d393
I can't seem to get these last two type errors solved. Maybe someone could help me with them.
Do you need any help resolving merge conflicts or making CI checks green?
Regarding type errors, you need to cast the const ModalUnstyled
to OverridableComponent<ModalUnstyledTypeMap>
as React.forwardRef messes up the generics.
The proper definition of types should allow for the removal of the last @ts-expect-error
in ModalUnstyled.spec.tsx.
I did what you suggested but this somehow gave me even more errors in the ModalUnstyled.test.tsx
.
Thank you for your patience but I think I need help resolving these last few errors.
You have done the majority of hard work, thanks! The remaining issue was missing types of React.createRef
. I added them.
I also removed one of the tests as prop forwarding is already being tested in describeConformanceUnstyled
.
Thank you so much for your patience and help, I really appreciate it!
Thank you for contributing! Feel free to tackle any other issues.