material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Published 20 hours ago • verified publisher icon mui

[Slider][base] Convert code to TypeScript

Open michaldudak opened this issue 3 years ago • 7 comments

Convert the SliderUnstyled and related modules (everything inside mui-base/src/SliderUnstyled) to TypeScript, to increase consistency with other MUI Base components. There should be no functional changes. Use other components as a reference.

michaldudak avatar Oct 11 '22 19:10 michaldudak

Can i work on this issue

i want to contribute to open source it would be great if u assign this to me

Tejas021 avatar Oct 12 '22 06:10 Tejas021

I've assigned FocusTrap to you. Once you're done with it, you can work on this one as well.

michaldudak avatar Oct 12 '22 07:10 michaldudak

hi @michaldudak can i work with this

paco9595 avatar Oct 13 '22 01:10 paco9595

It's all yours!

Let me know if you encounter any problems along the way. The Unstyled Slider is likely the most complex of the Base components still written in JS.

michaldudak avatar Oct 13 '22 07:10 michaldudak

@michaldudak i've created PR https://github.com/mui/material-ui/pull/35445 for this issue.

sai6855 avatar Dec 12 '22 09:12 sai6855

@michaldudak I see that there are issues to convert code to typescript for mui base components but i couldn't find issues which converts mui core components to typescript. Are mui core components not planned to convert to typescript yet? If not can I pick any component and convert

sai6855 avatar Dec 16 '22 11:12 sai6855

Do you mean Material UI components? If so, we don't plan to convert them. We will gradually reimplement them using MUI Base once it's stable and use Typescript then.

michaldudak avatar Dec 16 '22 11:12 michaldudak