material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Published 20 hours ago • verified publisher icon mui

[ToggleButton] `variant` prop is missing

Open burzaszsolt opened this issue 1 year ago • 4 comments

Duplicates

  • [X] I have searched the existing issues

Latest version

  • [X] I have tested the latest version

Current behavior 😯

I'm trying to add a variant to the ToggleButton component on theme level and there is no such interface that I could override with module augmentation.

Expected behavior 🤔

I would expect to have a variant prop available with an extendable interface as described in the docs.

Steps to reproduce 🕹

Please check this sandbox.

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

burzaszsolt avatar Sep 09 '22 07:09 burzaszsolt

I created a PR trying to fix the issue.

burzaszsolt avatar Sep 09 '22 10:09 burzaszsolt

Similar to https://github.com/mui/material-ui/issues/33510

siriwatknp avatar Sep 16 '22 03:09 siriwatknp

@siriwatknp Similar indeed! I see in this PR that you approached it a bit different than I did in my PR. Should I also remove the "standard" variant from the type definition and the prop types?

burzaszsolt avatar Sep 16 '22 08:09 burzaszsolt

@michaldudak Could you check please? ☝️ I can make those changes on my PR if needed.

burzaszsolt avatar Sep 21 '22 09:09 burzaszsolt

Duplicate of https://github.com/mui/material-ui/issues/33510, I've make the previous issue more general

mnajdova avatar Sep 30 '22 11:09 mnajdova