material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[TrapFocus] Rename TrapFocus to FocusTrap

Open kabernardes opened this issue 3 years ago • 9 comments

This PR fixes #33966

As explained in issue #33966, the component TrapFocus needed a change of name to FocusTrap.

kabernardes avatar Sep 07 '22 13:09 kabernardes

Details of bundle changes

Generated by :no_entry_sign: dangerJS against a07a6eddce462f11635e987dcd1a3e823797a3a2

mui-bot avatar Sep 07 '22 13:09 mui-bot

Hi, I had a problem with the ci/circleci: test_regressions-1, with exist something that I can do to correct this, please, let me know.

kabernardes avatar Sep 08 '22 13:09 kabernardes

Please merge in/rebase on the latest master. It contains the fix for the regression tests.

michaldudak avatar Sep 12 '22 08:09 michaldudak

Please merge in/rebase on the latest master. It contains the fix for the regression tests.

Thanks, if you need me to do any changes, just let me know.

kabernardes avatar Sep 12 '22 16:09 kabernardes

Good job! One thing left to do is to add a redirect for those who have bookmarked the old docs page. Please add entries for the docs and API pages in /docs/public/_redirects (somewhere around line 384)

I just did that!

kabernardes avatar Sep 13 '22 14:09 kabernardes

I saw you updated the old redirects. That's great, but we also need to introduce new ones pointing from /base/react-trap-focus to /base/react-focus-trap and from /base/api/trap-focus/ to /base/api/focus-trap/

michaldudak avatar Sep 14 '22 13:09 michaldudak

I saw you updated the old redirects. That's great, but we also need to introduce new ones pointing from /base/react-trap-focus to /base/react-focus-trap and from /base/api/trap-focus/ to /base/api/focus-trap/

Now, I think I did what you ask :)

kabernardes avatar Sep 15 '22 14:09 kabernardes

Could you please rebase on the latest master again? I'll do the final review then, and we should be able to merge this in.

michaldudak avatar Sep 20 '22 15:09 michaldudak

Could you please rebase on the latest master again? I'll do the final review then, and we should be able to merge this in.

Done!

kabernardes avatar Sep 21 '22 12:09 kabernardes