material-ui
material-ui copied to clipboard
[TrapFocus] Rename TrapFocus to FocusTrap
- [x] I have followed (at least) the PR section of the contributing guide.
This PR fixes #33966
As explained in issue #33966, the component TrapFocus needed a change of name to FocusTrap.
Generated by :no_entry_sign: dangerJS against a07a6eddce462f11635e987dcd1a3e823797a3a2
Hi, I had a problem with the ci/circleci: test_regressions-1, with exist something that I can do to correct this, please, let me know.
Please merge in/rebase on the latest master. It contains the fix for the regression tests.
Please merge in/rebase on the latest master. It contains the fix for the regression tests.
Thanks, if you need me to do any changes, just let me know.
Good job! One thing left to do is to add a redirect for those who have bookmarked the old docs page. Please add entries for the docs and API pages in /docs/public/_redirects (somewhere around line 384)
I just did that!
I saw you updated the old redirects. That's great, but we also need to introduce new ones pointing from /base/react-trap-focus to /base/react-focus-trap and from /base/api/trap-focus/ to /base/api/focus-trap/
I saw you updated the old redirects. That's great, but we also need to introduce new ones pointing from /base/react-trap-focus to /base/react-focus-trap and from /base/api/trap-focus/ to /base/api/focus-trap/
Now, I think I did what you ask :)
Could you please rebase on the latest master again? I'll do the final review then, and we should be able to merge this in.
Could you please rebase on the latest master again? I'll do the final review then, and we should be able to merge this in.
Done!