material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

Published 20 hours ago • verified publisher icon mui

[Breadcrumbs] Add ability to change icons

Open pratikkarad opened this issue 2 years ago • 1 comments

I have tested this fix locally and it works as expected.

Fixes #33232

pratikkarad avatar Aug 05 '22 09:08 pratikkarad

Netlify deploy preview

https://deploy-preview-33812--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by :no_entry_sign: dangerJS against b4fdce1a740962b51ca6305f78136f354bc0f658

mui-bot avatar Aug 05 '22 09:08 mui-bot

No I don't think so

propG avatar Aug 10 '22 09:08 propG

We need to use slots/slotProps. @pratikkarad If you are interested to continue working on this, feel free to re-open it.

ZeeshanTamboli avatar Mar 10 '23 11:03 ZeeshanTamboli

Hi @ZeeshanTamboli, let me fix this.

pratikkarad avatar Mar 10 '23 11:03 pratikkarad

Hi @ZeeshanTamboli, everything looks good but I'm getting the error of sorting the proptypes

/tmp/material-ui/packages/mui-material/src/Breadcrumbs/BreadcrumbCollapsed.js 74:3 error Prop types declarations should be sorted alphabetically react/sort-prop-types

Do we have to sort it manually or have a command for that?

Also facing the same issue on #33797

pratikkarad avatar Mar 10 '23 16:03 pratikkarad