material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[Autocomplete] prevent highlight index from resetting when options are added

Open cjtroiano opened this issue 3 years ago • 4 comments

fix #29508

cjtroiano avatar Jul 25 '22 16:07 cjtroiano

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 63e8baab13e286caec2ad9d012bedfde73f8bcbc

mui-bot avatar Jul 25 '22 16:07 mui-bot

Any movement on this? I'd be happy to try to help!

Maybe instead of always resetting or never resetting, it could reset only if the previously highlighted option no longer exists. If it still exists, it can remain highlighted. If it no longer exists, then we reset.

justintoman avatar Sep 16 '22 20:09 justintoman

I would also be very happy if this got prioritized, let me know if I can help somehow!

jimmycallin avatar Sep 26 '22 11:09 jimmycallin

@justintoman, @jimmycallin, feel free to give it a stab (just decide between the two of you who'll do it).

Maybe instead of always resetting or never resetting, it could reset only if the previously highlighted option no longer exists. If it still exists, it can remain highlighted. If it no longer exists, then we reset.

I think this should be the way to go. Let's implement this and see how it behaves live.

michaldudak avatar Dec 14 '22 10:12 michaldudak

Since there is no activity in this PR, I am closing it in favour of #35735.

ZeeshanTamboli avatar Jan 11 '23 07:01 ZeeshanTamboli