material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[docs] Undocumented `'default'` color

Open emlai opened this issue 2 years ago • 3 comments

Some components (at least IconButton and Chip) mention 'default' as the default color: Screen Shot 2022-06-03 at 15 30 14

But the meaning of this color value is not explained anywhere in the docs. The other color values are explained in the palette documentation.

emlai avatar Jun 03 '22 12:06 emlai

Thanks for pointing this out. In v5 we had an effort for removing all default values for the color prop, but in these components it seems like there is some kind of default color that is different than the rest. In my opinion we should rename it to something more descriptive, for example in the IconButton it seems to be none or transparent. I am adding the issue for the v6 milestone, as renaming the prop would be a braking change.

mnajdova avatar Oct 26 '22 07:10 mnajdova

Thanks for pointing this out. In v5 we had an effort for removing all default values for the color prop, but in these components it seems like there is some kind of default color that is different than he rest. In my opinion we should rename it to something more descriptive, for example in the IconButton it seems to be none or transparent. I am adding the issue for the v6 milestone, as renaming the prop would be a braking change.

I get issue when upgrade theme from MUI v4 to v5, do you have any docs related to remove default value in color props

vctqs1 avatar Dec 12 '22 06:12 vctqs1

@vctqs1 there should be info around this in https://mui.com/material-ui/migration/v5-component-changes/#%E2%9C%85-remove-default-color-prop

mnajdova avatar Dec 16 '22 11:12 mnajdova

Thank you

vctqs1 avatar Dec 20 '22 04:12 vctqs1