base-ui icon indicating copy to clipboard operation
base-ui copied to clipboard

[RadioGroup] Create new `RadioGroup` component

Open atomiks opened this issue 1 year ago • 1 comments

atomiks avatar Jul 24 '24 05:07 atomiks

Netlify deploy preview

https://deploy-preview-487--base-ui.netlify.app/

Generated by :no_entry_sign: dangerJS against ed766a2dfa32786af74e7a9c54cef77d0e4a3f4b

mui-bot avatar Jul 24 '24 05:07 mui-bot

@atomiks The docs demo is missing the "indicator", I think that's one (or perhaps the main?) point of confusion. There should be (whatever "should" means) a little dot inside the circle when it's selected. Like this https://helios.hashicorp.design/assets/components/form/radio-card/radio-card-states-2acdd2c7a5775a7479f7c497d3947804.png

colmtuite avatar Aug 20 '24 08:08 colmtuite

@colmtuite that's just one particular design though. The indicator can be anything, such as a plain filled-in white circle which is an outline when unchecked.

atomiks avatar Aug 23 '24 04:08 atomiks

@atomiks I don't see the keepMounted prop documented in the component API, am I missing/misunderstanding something?

colmtuite avatar Aug 28 '24 15:08 colmtuite