base-ui icon indicating copy to clipboard operation
base-ui copied to clipboard

[triggers] Fix React 17 support

Open atomiks opened this issue 2 weeks ago • 4 comments

Fixes #3300

The id should always exist from the useBaseUiId util, so this throw doesn't need to happen following the switch to the effect instead of callback ref.

atomiks avatar Nov 24 '25 13:11 atomiks

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3315
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3315

commit: 94cce76

pkg-pr-new[bot] avatar Nov 24 '25 13:11 pkg-pr-new[bot]

Deploy Preview for base-ui ready!

Name Link
Latest commit 7978de4eb29203d1b611041033ed27ec94614275
Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69246126f2c8de00082c1242
Deploy Preview https://deploy-preview-3315--base-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 24 '25 13:11 netlify[bot]

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-36B(-0.01%) ▼-15B(-0.01%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

mui-bot avatar Nov 24 '25 13:11 mui-bot

Deploy Preview for base-ui ready!

Name Link
Latest commit 94cce7652d13b3d18080544d0f3196dbefee248b
Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6924617bf7a13e0008728cfc
Deploy Preview https://deploy-preview-3315--base-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 24 '25 13:11 netlify[bot]

https://github.com/mui/base-ui/pull/3277 changes how trigger registration works and removes the undefined ID check. This PR can be closed.

michaldudak avatar Nov 26 '25 11:11 michaldudak