base-ui
base-ui copied to clipboard
[toggle-group][toggle] type safety
Closes #3142 .
[!NOTE] Originally this was meant to only introduce generic types to the
ToggleGroup, but i realized while working on this thatToggletoo had to be changed to handle a generic value.
- [x] I have followed (at least) the PR section of the contributing guide.
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3173
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3173
commit: 30892c5
Bundle size report
| Bundle | Parsed size | Gzip size |
|---|---|---|
| @base-ui-components/react | ▼-1B(0.00%) | 🔺+7B(+0.01%) |
Check out the code infra dashboard for more information about this PR.
Deploy Preview for base-ui ready!
| Name | Link |
|---|---|
| Latest commit | 30892c5334040d40457b09a7dc80f7b90c257d3f |
| Latest deploy log | https://app.netlify.com/projects/base-ui/deploys/692723aeb75ef2000821d719 |
| Deploy Preview | https://deploy-preview-3173--base-ui.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
it seems like this is failing over something i have not affected...
would appreciate help
@michaelhazan My bad, I remembered we actually do this intentionally:
the value prop and onValueChange don't depend on if the multiple is true or not causing the component to always expect and array
Accordion is the same and the value is always an array
@michaelhazan My bad, I remembered we actually do this intentionally:
the value prop and onValueChange don't depend on if the multiple is true or not causing the component to always expect and array
Accordion is the same and the value is always an array
@mj12albert lmao, no worries, I'll work on keeping it an array while having it still be generic